feat: add _freshIndicator support for partial form submits#3753
Merged
Conversation
Previously only anchor clicks toggled the _freshIndicator signal during partial navigation. This extends the same behavior to form submissions, checking the submitter element first and falling back to the form element. Closes #3504 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds a "Loading indicators" section to the partials docs covering the _freshIndicator property, including the new submitter-over-form precedence behavior for form submissions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_freshIndicatorloading signal to form submissions, not just anchor clicksCloses #3504
Test plan
deno test -A packages/fresh/tests/partials_test.tsx --filter "submit form indicator"— all 3 new tests pass🤖 Generated with Claude Code